.github/workflows: install ginkgo for test suite build test #16605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test suite build check for the individual commits of a PR currently fails due to missing ginkgo binary. Install ginkgo v1.12.1 (as per go.mod). Fixes: e260ba9 (".github/workflows: verify that each commit builds for test suite changes") Signed-off-by: Tobias Klauser <tobias@cilium.io>
|
See e.g. https://github.com/cilium/cilium/pull/16495/checks?check_run_id=2873663278 for a recent failure. |
pchaigno
approved these changes
Jun 21, 2021
christarazi
approved these changes
Jun 21, 2021
tklauser
added
the
ready-to-merge
|
Reviews are in and GH actions passed. Marked as ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test suite build check for the individual commits of a PR currently
fails due to missing ginkgo binary. Install ginkgo v1.12.1 (as per
go.mod).
Fixes: e260ba9 (".github/workflows: verify that each commit builds for test suite changes")