test: Update list of allowed level=error logs #16623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cilium#16477 was merged and a new error, cilium#16402 (comment) was discovered since the PR disallowing level=error in CI was merged. Signed-off-by: Paul Chaignon <paul@cilium.io>
Suggested-by: Joe Stringer <joe@cilium.io> Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added
area/CI
joestringer
approved these changes
Jun 22, 2021
christarazi
approved these changes
Jun 22, 2021
|
I opened #16632 for the new flake in k8s-1.20-kernel-4.19 as it's clearly unrelated (not failing because of a bad log message). Marking as ready to merge. |
pchaigno
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #16395.
The first commit updates the list now that we have feedback from running with #16395 in CI for a while. The second commit adds a comment to warn against adding more exceptions.