Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Don't skip encapsulation tests on GKE #16627

Merged
merged 1 commit into from Jun 25, 2021
Merged

test: Don't skip encapsulation tests on GKE #16627

merged 1 commit into from Jun 25, 2021

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Jun 22, 2021 •
edited

We can run with VXLAN encapsulation enabled on GKE; there's no need to skip those tests.

@pchaigno pchaigno added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Jun 22, 2021
@pchaigno pchaigno force-pushed the remove-unnecessary-skip-gke branch from 0440da9 to 88a086d Compare June 23, 2021 21:50
@pchaigno pchaigno marked this pull request as ready for review June 24, 2021 07:24
@pchaigno pchaigno requested a review from a team June 24, 2021 07:24
@pchaigno pchaigno requested a review from a team as a code owner June 24, 2021 07:24
@pchaigno
test: Don't skip encapsulation tests on GKE
b369073 
Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno force-pushed the remove-unnecessary-skip-gke branch from 88a086d to b369073 Compare June 24, 2021 12:42
@pchaigno
Copy link
Member Author

test-gke

@pchaigno pchaigno requested a review from tklauser June 24, 2021 12:43
tklauser
tklauser approved these changes Jun 24, 2021
View reviewed changes
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 24, 2021
@errordeveloper errordeveloper merged commit 40b88a6 into cilium:master Jun 25, 2021
@pchaigno pchaigno deleted the remove-unnecessary-skip-gke branch June 25, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@jrfastab jrfastab Awaiting requested review from jrfastab

Assignees

@jrfastab jrfastab

Labels
area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pchaigno @tklauser @errordeveloper @jrfastab