tests: re-enable Host Firewall for AutoDirectNodeRoutes test and encryption + direct routing #16652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmonnet
added
area/CI-improvement
|
test-only --focus="K8sDatapathConfig" |
pchaigno
approved these changes
Jun 25, 2021
pchaigno
reviewed
Jun 25, 2021
qmonnet
force-pushed
the
pr/dpc-enable-hfw-tests
branch
from
9701a46
to
ea8aefe
Compare
|
test-only --focus="K8sDatapathConfig" |
|
test-1.16-netnext |
pchaigno
approved these changes
Jun 28, 2021
|
test-gke |
qmonnet
added
the
dont-merge/needs-rebase
qmonnet
force-pushed
the
pr/dpc-enable-hfw-tests
branch
from
ea8aefe
to
db9c52b
Compare
qmonnet
removed
the
dont-merge/needs-rebase
|
test-me-please |
This reverts commit be4e93e. Issue cilium#12205 has been fixed via cilium#16136, and the Host Firewall can be used again in the tests. Signed-off-by: Quentin Monnet <quentin@isovalent.com>
The test was disabled because of issue cilium#12205: When bpf_host was loading on the native device, the source identity of packet on the destination node was resolved to WORLD and policy enforcement would fail. This has now been fixed via cilium#16136, and we can run the test again. Also adjust the conditions for the test, to reflect the changes to surrounding IPSec tests from f1209d0 ("test: Enable IPSec tests on 4.19"). Signed-off-by: Quentin Monnet <quentin@isovalent.com>
qmonnet
force-pushed
the
pr/dpc-enable-hfw-tests
branch
from
db9c52b
to
d870d39
Compare
|
Rebased because I left the PR aside for some time :/. I'm not running the full CI since the change is on the e2e tests. test-1.16-netnext [Edit] Since the above passed we are good to go. |
qmonnet
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #12205 has been fixed via #16136, and the Host Firewall can be used again in the tests. Renable those tests that we had disabled because of the issue.