.github: Fix image digest job printing #16660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
joestringer
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
Commit ba728f0 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
maintainer-s-little-helper
bot
added
the
dont-merge/needs-sign-off
|
Commits ba728f0, 61e036a515b2c514676dc05908c31eba96584476 do not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
|
Great, looks like the fix works: https://github.com/cilium/cilium/pull/16660/checks?check_run_id=2934571036
|
Commit 044afab ("ci: Set up qemu in images workflow and build cilium-test") introduced a new dependency for the "Display image digests" job which provides a nice single page that developers can use to find all of the CI image artifacts generated from the PR. Unfortunately the new dependency is conditionally skipped, and when it is skipped, the display digests job is also skipped because the dependency is skipped. This is a known behaviour of GitHub actions/runner, issue 491. This commit works around the issue by explicitly running the job if the dependency was skipped, allowing the "display image digests" job to run even when the qemu job is skipped. Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
force-pushed
the
pr/joe/fix-image-ci-display-digests
branch
from
61e036a
to
6dad17f
Compare
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
nbusseneau
approved these changes
Jun 29, 2021
nbusseneau
added
the
ready-to-merge
aanm
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 044afab ("ci: Set up qemu in images workflow and build
cilium-test") introduced a new dependency for the "Display image digests"
job which provides a nice single page that developers can use to find
all of the CI image artifacts generated from the PR. Unfortunately the
new dependency is conditionally skipped, and when it is skipped, the
display digests job is also skipped because the dependency is skipped.
This is a known behaviour of GitHub actions/runner, issue 491.
This commit works around the issue by explicitly running the job if the
dependency was skipped, allowing the "display image digests" job to run
even when the qemu job is skipped.
This PR proposes the workaround listed on actions/runner#491 .