Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.8] ipam: Add extra debug info when blacklisting routes #16678

Merged

Conversation

christarazi
Copy link
Member

In order to debug failures such as
#16677, we need more information in the
logs to understand why the route was blacklisted.

Signed-off-by: Chris Tarazi chris@isovalent.com

@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.8 kind/backports This PR provides functionality previously merged into master. labels Jun 29, 2021
@christarazi christarazi requested review from a team and twpayne and removed request for a team June 29, 2021 00:31
@christarazi christarazi marked this pull request as ready for review June 29, 2021 00:31
@christarazi christarazi requested a review from a team as a code owner June 29, 2021 00:31
@christarazi christarazi changed the title ipam: Add extra debug info blacklisting routes [v1.8] ipam: Add extra debug info blacklisting routes Jun 29, 2021
@christarazi christarazi force-pushed the pr/christarazi/v1.8-blacklist-route-debug branch from 365f7f2 to 09eec4f Compare June 29, 2021 00:33
@christarazi christarazi changed the title [v1.8] ipam: Add extra debug info blacklisting routes [v1.8] ipam: Add extra debug info when blacklisting routes Jun 29, 2021
@christarazi
Copy link
Member Author

test-backport-1.8

@twpayne
Copy link
Contributor

twpayne commented Jun 29, 2021

k8s-1.11-kernel-netnext test failure is #12511.

@christarazi christarazi force-pushed the pr/christarazi/v1.8-blacklist-route-debug branch from 09eec4f to 6a720e2 Compare June 29, 2021 18:49
@christarazi
Copy link
Member Author

test-backport-1.8

@joamaki joamaki added the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Jul 1, 2021
@pchaigno
Copy link
Member

pchaigno commented Jul 1, 2021

This PR needs a rebase given all backports PRs should be up-to-date with their branch before being merged.

In order to debug failures such as
cilium#16677, we need more information in the
logs to understand why the route was blacklisted.

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi christarazi force-pushed the pr/christarazi/v1.8-blacklist-route-debug branch from 6a720e2 to 226e21b Compare July 1, 2021 23:34
@christarazi christarazi removed the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Jul 1, 2021
@christarazi christarazi added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 7, 2021
@aditighag
Copy link
Member

Needs a rebase since this v1.8 PR was merged yesterday - #16797.

@aditighag aditighag added dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. and removed dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. labels Jul 7, 2021
@aditighag aditighag merged commit a5a7bb0 into cilium:v1.8 Jul 7, 2021
@christarazi christarazi deleted the pr/christarazi/v1.8-blacklist-route-debug branch July 7, 2021 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.8] Cilium blacklists / blocks almost all routes leading to IPAM exhaustion errors
5 participants