-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v1.8] ipam: Add extra debug info when blacklisting routes #16678
Merged
aditighag
merged 1 commit into
cilium:v1.8
from
christarazi:pr/christarazi/v1.8-blacklist-route-debug
Jul 7, 2021
Merged
[v1.8] ipam: Add extra debug info when blacklisting routes #16678
aditighag
merged 1 commit into
cilium:v1.8
from
christarazi:pr/christarazi/v1.8-blacklist-route-debug
Jul 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
backport/1.8
kind/backports
This PR provides functionality previously merged into master.
labels
Jun 29, 2021
christarazi
requested review from
a team and
twpayne
and removed request for
a team
June 29, 2021 00:31
christarazi
changed the title
ipam: Add extra debug info blacklisting routes
[v1.8] ipam: Add extra debug info blacklisting routes
Jun 29, 2021
christarazi
force-pushed
the
pr/christarazi/v1.8-blacklist-route-debug
branch
from
June 29, 2021 00:33
365f7f2
to
09eec4f
Compare
christarazi
changed the title
[v1.8] ipam: Add extra debug info blacklisting routes
[v1.8] ipam: Add extra debug info when blacklisting routes
Jun 29, 2021
test-backport-1.8 |
k8s-1.11-kernel-netnext test failure is #12511. |
twpayne
approved these changes
Jun 29, 2021
christarazi
force-pushed
the
pr/christarazi/v1.8-blacklist-route-debug
branch
from
June 29, 2021 18:49
09eec4f
to
6a720e2
Compare
test-backport-1.8 |
joamaki
added
the
dont-merge/needs-rebase
This PR needs to be rebased because it has merge conflicts.
label
Jul 1, 2021
This PR needs a rebase given all backports PRs should be up-to-date with their branch before being merged. |
In order to debug failures such as cilium#16677, we need more information in the logs to understand why the route was blacklisted. Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
force-pushed
the
pr/christarazi/v1.8-blacklist-route-debug
branch
from
July 1, 2021 23:34
6a720e2
to
226e21b
Compare
christarazi
removed
the
dont-merge/needs-rebase
This PR needs to be rebased because it has merge conflicts.
label
Jul 1, 2021
pchaigno
approved these changes
Jul 2, 2021
christarazi
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Jul 7, 2021
Needs a rebase since this v1.8 PR was merged yesterday - #16797. |
aditighag
added
dont-merge/needs-rebase
This PR needs to be rebased because it has merge conflicts.
and removed
dont-merge/needs-rebase
This PR needs to be rebased because it has merge conflicts.
labels
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/backports
This PR provides functionality previously merged into master.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to debug failures such as
#16677, we need more information in the
logs to understand why the route was blacklisted.
Signed-off-by: Chris Tarazi chris@isovalent.com