docs: deprecate native-routing-cidr from v1.10 #16688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that the change to deprecate the native-routing-cidr option in favor of ipv4-native-routing-cidr was supposed to be backported to v1.10, update the docs to move the deprecation notice under the v1.10 section. Signed-off-by: Gilberto Bertin <gilberto@isovalent.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
jibi
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
tklauser
approved these changes
Jun 29, 2021
qmonnet
approved these changes
Jun 29, 2021
I'd say it's OK as this change is not going to break any existing setup |
|
Will it trigger warnings if the old option name is used? |
Yes: |
|
Discussed offline, and even with the warning it seems OK in the current case. No objection from my side :). |
qmonnet
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that the change to deprecate the native-routing-cidr option in
favor of ipv4-native-routing-cidr was supposed to be backported to
v1.10, update the docs to move the deprecation notice under the v1.10
section.