Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "docs: deprecate native-routing-cidr from v1.10" #16695

Merged

Conversation

jibi
Copy link
Member

@jibi jibi commented Jun 30, 2021

This reverts commit 4bd2188.

Although the upgrade impact was minimal, #16646 has a non trivial downgrade impact (see #16646 (comment)) and so should not be backported to v1.10.

This reverts commit 4bd2188.

Signed-off-by: Gilberto Bertin <gilberto@isovalent.com>
@jibi jibi added the area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. label Jun 30, 2021
@jibi jibi requested review from tklauser and qmonnet June 30, 2021 05:22
@jibi jibi requested a review from a team as a code owner June 30, 2021 05:22
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 30, 2021
@jibi jibi added release-note/misc This PR makes changes that have no direct user impact. and removed area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. labels Jun 30, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 30, 2021
@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Jun 30, 2021
@errordeveloper errordeveloper merged commit f8e794b into master Jun 30, 2021
@errordeveloper errordeveloper deleted the pr/jibi/revert-deprecate-native-routing-cidr-v1.10 branch June 30, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants