Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add klog lock error to allow-list #16698

Merged
merged 1 commit into from Jun 30, 2021

Conversation

pchaigno
Copy link
Member

This error message happened in CI and seems to be a less frequent variation of known klog error messages [1].

1 - #16402 (comment)

@pchaigno pchaigno added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Jun 30, 2021
@pchaigno pchaigno requested a review from a team as a code owner June 30, 2021 07:18
@pchaigno pchaigno requested a review from nbusseneau June 30, 2021 07:18
test/helpers/cons.go Outdated Show resolved Hide resolved
This error message happened in CI and seems to be a less frequent
variation of known klog error messages [1].

1 - cilium#16402 (comment)
Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno
Copy link
Member Author

Tests are compiling, previous end-to-end test runs were okay, and review is in. Marking as ready and merging.

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 30, 2021
@pchaigno pchaigno merged commit a2a2496 into cilium:master Jun 30, 2021
@pchaigno pchaigno deleted the ci-add-error-allow-list branch June 30, 2021 17:07
@joestringer
Copy link
Member

@pchaigno wait, how do we know that Cilium isn't causing the apiserver connectivity issue that leads to http2: client connection lost ?

@pchaigno
Copy link
Member Author

It might. It's not a new error, but we should definitely track it and figure out the root cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants