Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Debug IPsec test #16700

Merged
merged 2 commits into from Jul 2, 2021
Merged

test: Debug IPsec test #16700

merged 2 commits into from Jul 2, 2021

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Jun 30, 2021

First commit cleans up some test conditions. The second adds some debug logs in case of failure, to help debug #16699.

Related: #16699.

Signed-off-by: Paul Chaignon <paul@cilium.io>
In the IPsec test with native routing, the Cilium agent sometimes fails
to determine the correct IPsec interface and fatals. In such case, we
can't rely on the bugtool report to inspect routes (from which the
interface is determined).

This commit therefore dumps additional logs using the hostns
log-gatherer pods.

Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno added area/CI Continuous Integration testing issue or flake area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. release-note/ci This PR makes changes to the CI. labels Jun 30, 2021
@pchaigno
Copy link
Member Author

test-1.19-5.4

6 similar comments
@pchaigno
Copy link
Member Author

test-1.19-5.4

@pchaigno
Copy link
Member Author

test-1.19-5.4

@pchaigno
Copy link
Member Author

test-1.19-5.4

@pchaigno
Copy link
Member Author

pchaigno commented Jul 1, 2021

test-1.19-5.4

@pchaigno
Copy link
Member Author

pchaigno commented Jul 1, 2021

test-1.19-5.4

@nebril
Copy link
Member

nebril commented Jul 1, 2021

test-1.19-5.4

@pchaigno pchaigno marked this pull request as ready for review July 1, 2021 13:10
@pchaigno pchaigno requested a review from a team July 1, 2021 13:10
@pchaigno pchaigno requested a review from a team as a code owner July 1, 2021 13:10
Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't the bugtool retrieve this output?

@pchaigno
Copy link
Member Author

pchaigno commented Jul 1, 2021

Why can't the bugtool retrieve this output?

Because the Cilium agent is fataling, so by the time we get the bugtool reports, the Cilium pods are crashlooping and we can't run anything on them. See https://jenkins.cilium.io/job/cilium-master-k8s-1.19-kernel-5.4/367/testReport/junit/Suite-k8s-1/19/K8sDatapathConfig_Transparent_encryption_DirectRouting_Check_connectivity_with_transparent_encryption_and_direct_routing/ from #16699.

@pchaigno
Copy link
Member Author

pchaigno commented Jul 2, 2021

The changes here are not specific to IPsec or the datapath so skipping that review. Tests are passing. Merging.

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 2, 2021
@pchaigno pchaigno merged commit 12a4a48 into cilium:master Jul 2, 2021
@pchaigno pchaigno deleted the debug-ipsec-test branch July 2, 2021 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants