ci/conformance: Various image-related fixes #16715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull in the correct image version built as part of CI when deploying `clustermesh-apiserver`. Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
This commit extends the conformance tests (all of which are using `cilium hubble enable` to deploy Hubble Relay) to also wait for the `hubble-relay-ci` image to be built. In the multicluster test, we also wait for the `clustermesh-apiserver-ci` image. Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro
added
area/CI-improvement
|
Runs from the validation PR:
Not all of them are green, but since this is an improvement over the status quo and the steps affected by this PR do have passed, I think we should not block the merge of this PR. |
|
Marking this ready-to-merge, exempt from the merge freeze, as it is improving/fixing CI flakes. |
gandro
added
the
ready-to-merge
|
Do we need equivalent changes on 1.10? |
Yes. From a first glance, looks like this patch however also requires #16363. Marking both for backport. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two commits (see description), fixing two issues around the usage of our CI images:
clustermesh-apiserver-ciin the clustermesh testhubble-relay-ciandclustermesh-apiserver-ciwhere neededThis PR is tested in #16714