Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix code-block for bpf mount example #16719

Merged
merged 1 commit into from Jul 1, 2021
Merged

Conversation

aanm
Copy link
Member

@aanm aanm commented Jul 1, 2021

Fixes: e9166c4 ("docs: use ".. code-block:: shell-session" wherever relevant")
Signed-off-by: André Martins andre@cilium.io

Fixes: e9166c4 ("docs: use ".. code-block:: shell-session" wherever relevant")
Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm added the area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. label Jul 1, 2021
@aanm aanm requested a review from a team July 1, 2021 02:51
@aanm aanm requested a review from a team as a code owner July 1, 2021 02:51
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 1, 2021
@aanm aanm requested review from jrfastab and qmonnet July 1, 2021 02:52
@aanm aanm added needs-backport/1.10 release-note/misc This PR makes changes that have no direct user impact. labels Jul 1, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 1, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.2 Jul 1, 2021
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh! Thanks for the fix

@qmonnet
Copy link
Member

qmonnet commented Jul 1, 2021

Pretty confident we don't have to wait for John for this one, I'm marking as ready to merge.

@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 1, 2021
@aanm aanm merged commit 8a95d23 into cilium:master Jul 1, 2021
@aanm aanm deleted the pr/fix-doc-bpf branch July 1, 2021 13:33
@aanm aanm added this to Needs backport from master in 1.10.3 Jul 2, 2021
@aanm aanm removed this from Needs backport from master in 1.10.2 Jul 2, 2021
@aanm aanm moved this from Needs backport from master to Backport done to v1.10 in 1.10.3 Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.3
Backport done to v1.10
Development

Successfully merging this pull request may close these issues.

None yet

5 participants