Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and add more commands in CI sysdumps #16721

Merged
merged 3 commits into from Jul 1, 2021

Conversation

aanm
Copy link
Member

@aanm aanm commented Jul 1, 2021

In order to further debug #16720 we need to retrieve kube-apiserver logs which is being added by this PR.

Fixes #14293

aanm added 3 commits July 1, 2021 06:11
When using journalctl to read the logs of another system, one need
to explicitly pass -D and the directory containing the logs to
successfully read the log messages.

Fixes: a9285f4 ("[CI] Move vagrant start script to separate file")
Signed-off-by: André Martins <andre@cilium.io>
cilium/log-gatherer:v1.1 is not mutable thus we don't need to always
performing a pull of that docker image from docker hub.

Fixes: a9285f4 ("[CI] Move vagrant start script to separate file")
Signed-off-by: André Martins <andre@cilium.io>
To help debug certain flakes, we need kube-apiserver logs available in
the test sysdump. This commit adds the ability to retrieve such logs.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm added area/CI Continuous Integration testing issue or flake needs-backport/1.8 labels Jul 1, 2021
@aanm aanm requested a review from a team as a code owner July 1, 2021 04:21
@aanm aanm requested a review from tklauser July 1, 2021 04:21
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 1, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.11 Jul 1, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.9.9 Jul 1, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.2 Jul 1, 2021
@aanm aanm added the release-note/ci This PR makes changes to the CI. label Jul 1, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 1, 2021
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing missing in CI 3.0 I guess. Could we collect those in sysdumps as well?

@aanm aanm merged commit 445af9a into cilium:master Jul 1, 2021
@aanm aanm deleted the pr/add-logs-kube-apiserver branch July 1, 2021 13:35
@joestringer
Copy link
Member

Collecting apiserver logs in generic sysdump is a bit tricky because we have no guarantee of where the apiserver is running; it's commonly not even part of the cluster (eg managed k8s environments like EKS, GKE, etc.).

@aanm aanm added this to Needs backport from master in 1.10.3 Jul 2, 2021
@aanm aanm removed this from Needs backport from master in 1.10.2 Jul 2, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.9 in 1.9.9 Jul 5, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.9 in 1.9.9 Jul 5, 2021
@aanm aanm moved this from Needs backport from master to Backport done to v1.10 in 1.10.3 Jul 15, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.11 Jul 15, 2021
@joestringer joestringer added this to Backport pending to v1.9 in 1.9.10 Jul 19, 2021
@joestringer joestringer removed this from Backport pending to v1.9 in 1.9.9 Jul 19, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Backport done to v1.9 in 1.9.9 Jul 19, 2021
@joestringer joestringer removed this from Backport pending to v1.9 in 1.9.10 Jul 19, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.11 Jul 22, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.11 Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.10.3
Backport done to v1.10
1.8.11
Backport done to v1.8
1.9.9
Backport done to v1.9
Development

Successfully merging this pull request may close these issues.

Empty kubelet logs
6 participants