Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datapath: Use iproute2+libbpf #16727

Merged
merged 3 commits into from Aug 11, 2021
Merged

datapath: Use iproute2+libbpf #16727

merged 3 commits into from Aug 11, 2021

Conversation

brb
Copy link
Member

@brb brb commented Jul 1, 2021 •
edited

See commit msgs.

Fix #16757

Use iproute2 with libbpf for loading datapath BPF programs

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 1, 2021
@brb brb had a problem deploying to release-base-images July 1, 2021 07:52 Failure
@brb brb had a problem deploying to release-base-images July 1, 2021 07:52 Failure
@brb brb temporarily deployed to release-base-images July 1, 2021 09:13 Inactive
@brb brb had a problem deploying to release-base-images July 1, 2021 09:13 Failure
@brb brb temporarily deployed to release-base-images July 1, 2021 09:21 Inactive
@brb brb temporarily deployed to release-base-images July 1, 2021 09:21 Inactive
@brb brb had a problem deploying to release-base-images July 1, 2021 09:44 Error
@brb brb had a problem deploying to release-base-images July 1, 2021 09:44 Error
@brb
Copy link
Member Author

brb commented Jul 1, 2021

test-me-please

@brb
Copy link
Member Author

brb commented Jul 1, 2021

test-1.16-netnext

@brb
Copy link
Member Author

brb commented Jul 1, 2021

test-1.19-5.4

@brb
Copy link
Member Author

brb commented Jul 1, 2021

test-1.20-4.19

@brb
Copy link
Member Author

brb commented Jul 1, 2021

test-1.21-4.9

@brb
Copy link
Member Author

brb commented Jul 1, 2021

test-runtime

@brb brb had a problem deploying to release-base-images July 1, 2021 12:26 Error
@brb brb had a problem deploying to release-base-images July 1, 2021 12:26 Error
@brb
Copy link
Member Author

brb commented Jul 1, 2021

test-me-please

@brb brb had a problem deploying to release-base-images July 7, 2021 13:45 Error
@brb brb had a problem deploying to release-base-images July 7, 2021 13:45 Error
@brb brb temporarily deployed to release-base-images July 7, 2021 13:48 Inactive
@brb brb had a problem deploying to release-base-images July 7, 2021 13:48 Failure
@brb brb temporarily deployed to release-base-images July 7, 2021 14:29 Inactive
@brb brb temporarily deployed to release-base-images July 7, 2021 14:29 Inactive
@brb brb marked this pull request as ready for review August 10, 2021 15:00
@brb brb requested a review from a team August 10, 2021 15:00
@brb brb requested review from a team as code owners August 10, 2021 15:00
@pchaigno
Copy link
Member

FYI, I was surprised verifier-test.sh didn't need an update for the cgroup programs, but then discovered we skip those programs in that script by error. I filed #17125 for it.

@pchaigno pchaigno removed their assignment Aug 10, 2021
@joestringer
Copy link
Member

release-note/minor is to help inform users about changes that impact them. As far as I know this should not have any user-facing impact. Should this be release-note/misc instead?

@pchaigno pchaigno added the sig/loader Impacts the loading of BPF programs into the kernel. label Aug 10, 2021
@brb brb added release-note/misc This PR makes changes that have no direct user impact. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. and removed release-note/minor This PR changes functionality that users may find relevant to operating Cilium. labels Aug 11, 2021
@brb
Copy link
Member Author

brb commented Aug 11, 2021

Considering #16727 (comment), I'm marking this as ready to be merged.

@gandro gandro merged commit 6ce6238 into master Aug 11, 2021
@gandro gandro deleted the pr/brb/iproute2+libbpf branch August 11, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@borkmann borkmann borkmann approved these changes

@pchaigno pchaigno pchaigno approved these changes

@joamaki joamaki Awaiting requested review from joamaki

Assignees

@joamaki joamaki

Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/loader Impacts the loading of BPF programs into the kernel.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

datapath: Loading with iproute2+libbpf
7 participants
@brb @pchaigno @joestringer @tklauser @borkmann @gandro @joamaki