-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update link to be specific to Janitors #16732
Conversation
The link for PRs waiting for Janitor reviews including all PRs waiting for a review from the person clicking the link. This commit fixes it. Signed-off-by: Paul Chaignon <paul@cilium.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix, thanks
Documentation-only change so fine to merge despite merge freeze. |
How do regular contributors find the old link? The idea of the old one is to make sure that you are following up on everything that your review is requested for. |
But that's a different issue, no? When I perform a round of Janitoring, I only want to see the PRs that require me as a Janitor. I'll typically review the rest at a different time. For general reviews requested from me, there's a link in https://docs.cilium.io/en/latest/contributing/development/contributing_guide/#pull-requests-review-process-for-committers. |
OK thanks, I had to read it a few times to find the link even once you pointed it out above. I think we could probably improve the wording to make this clearer but it's not such a big deal. I'll take a note so if it bothers me again I'll improve the docs. |
The link for PRs waiting for Janitor reviews including all PRs waiting for a review from the person clicking the link. This pull request fixes it.