Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update link to be specific to Janitors #16732

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Jul 1, 2021

The link for PRs waiting for Janitor reviews including all PRs waiting for a review from the person clicking the link. This pull request fixes it.

The link for PRs waiting for Janitor reviews including all PRs waiting
for a review from the person clicking the link. This commit fixes it.

Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. sig/contributing Impacts contribution workflow, guidelines, and tools. labels Jul 1, 2021
@pchaigno pchaigno requested review from a team as code owners July 1, 2021 09:17
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 1, 2021
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, thanks

@qmonnet qmonnet added the release-note/misc This PR makes changes that have no direct user impact. label Jul 1, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 1, 2021
@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 1, 2021
@pchaigno
Copy link
Member Author

pchaigno commented Jul 1, 2021

Documentation-only change so fine to merge despite merge freeze.

@pchaigno pchaigno merged commit dd02151 into cilium:master Jul 1, 2021
@pchaigno pchaigno deleted the janitor-docs-update-link branch July 1, 2021 14:02
@joestringer
Copy link
Member

How do regular contributors find the old link? The idea of the old one is to make sure that you are following up on everything that your review is requested for.

@pchaigno
Copy link
Member Author

pchaigno commented Jul 8, 2021

But that's a different issue, no? When I perform a round of Janitoring, I only want to see the PRs that require me as a Janitor. I'll typically review the rest at a different time.

For general reviews requested from me, there's a link in https://docs.cilium.io/en/latest/contributing/development/contributing_guide/#pull-requests-review-process-for-committers.

@joestringer
Copy link
Member

OK thanks, I had to read it a few times to find the link even once you pointed it out above. I think we could probably improve the wording to make this clearer but it's not such a big deal. I'll take a note so if it bothers me again I'll improve the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/contributing Impacts contribution workflow, guidelines, and tools.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants