checkpatch: update image to improve checks and extend to all commits #16739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull the changes from cilium/image-tools#121: - The checkpatch.pl script is now run for _all_ commits of the PR, instead of just the commits touching files under `bpf/`. We do not want to check the code in directories other than `bpf/`; the interest here is to run the checks on the commit log messages. Therefore, pass commit logs without a diff to checkpatch for commits unrelated to `bpf/`. This makes more checks but note that passing checkpatch is not currently required by the CI for validating the PRs on the Cilium repository. - Format errors and warnings based on the available workflow commands for GitHub Actions. This should make the output easier to read on GitHub. - Update the checkpatch.pl patch itself (and its spelling file) from the version coming with kernel 5.12. Signed-off-by: Quentin Monnet <quentin@isovalent.com>
qmonnet
added
area/CI-improvement
nbusseneau
approved these changes
Jul 1, 2021
tklauser
approved these changes
Jul 2, 2021
qmonnet
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull the changes from cilium/image-tools#121:
The checkpatch.pl script is now run for all commits of the PR, instead of just the commits touching files under
bpf/. We do not want to check the code in directories other thanbpf/; the interest here is to run the checks on the commit log messages. Therefore, pass commit logs without a diff to checkpatch for commits unrelated tobpf/. This makes more checks but note that passing checkpatch is not currently required by the CI for validating the PRs on the Cilium repository.Format errors and warnings based on the available workflow commands for GitHub Actions. This should make the output easier to read on GitHub.
Update the checkpatch.pl patch itself (and its spelling file) from the version coming with kernel 5.12.