-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(k3s): add back the flag to disable network policies #16755
Conversation
This was actually added in cilium#13783 but got removed again after some other changes. That flag is required because otherwise any liveness or readiness probes will be classified as *world* traffic and get dropped if network policies are installed. Signed-off-by: Rio Kierkels <riokierkels@gmail.com>
I just now notice that it's removing it from the agent and it was never set for the server. In that case that commit is correct because the agent doesn't support that flag only the server does. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, if this is a matter of passing the option to the correct entity then fine by me.
/Cc @seanmwinn for a quick review, as he is more familiar with the topic.
I'm not particularly familiar with this topic as many of the flags for k3s have changed since we initially published a k3s getting started guide. I would need to test this to validate the reported behavior as well as the fix. |
@seanmwinn Thanks, I thought maybe you knew about that option. If you need to run tests but don't have cycles for this at the moment, I think we should just go ahead and merge the PR. After all, this is simply a documentation change adding one option back. I'll mark the PR as ready-to-merge. Thanks! |
This was actually added in #13783 but got removed again after some other changes.
That flag is required because otherwise any liveness or readiness probes will be classified as world traffic and get
dropped if network policies are installed.
Signed-off-by: Rio Kierkels riokierkels@gmail.com