test: Don't pass namespace for CCNPs #16768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
area/CI
pchaigno
force-pushed
the
fix-warn-ns-for-ccnp
branch
3 times, most recently
from
bc006ab
to
b17c7ca
Compare
maintainer-s-little-helper
bot
assigned jrfastab, nbusseneau and kkourt and unassigned jrfastab
nbusseneau
approved these changes
Jul 15, 2021
jrfastab
approved these changes
Jul 20, 2021
kkourt
approved these changes
Jul 20, 2021
There was a problem hiding this comment.
nit: I think @nbusseneau's comment makes sense. It would be good to make the intention clear.
Host policies are CCNPs and therefore not namespaces. To avoid the
following warning, we should therefore avoid passing a namespace name to
kubectl apply and kubectl delete.
warning: deleting cluster-scoped resources, not scoped to the provided namespace
Reported-by: Joe Stringer <joe@cilium.io>
Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
fix-warn-ns-for-ccnp
branch
from
b17c7ca
to
cc25de8
Compare
|
test-me-please |
nbusseneau
approved these changes
Jul 26, 2021
pchaigno
added
the
ready-to-merge
vadorovsky
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Host policies are CCNPs and therefore not namespaces. To avoid the following warning, we should therefore avoid passing a namespace name to
kubectl applyandkubectl delete.