Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/Bookinfo: Collect full artifact in case of failure #16775

Merged
merged 1 commit into from Jul 7, 2021
Merged

test/Bookinfo: Collect full artifact in case of failure #16775

merged 1 commit into from Jul 7, 2021

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Jul 5, 2021

Tested locally with a test purposely broken.

Should help debug #16632.

Fixes: #16470.
/cc @brb

@pchaigno pchaigno added kind/bug/CI This is a bug in the testing code. area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Jul 5, 2021
@pchaigno pchaigno requested a review from a team as a code owner July 5, 2021 09:34
@pchaigno pchaigno requested a review from nebril July 5, 2021 09:34
@pchaigno
test/Bookinfo: Collect full artifact in case of failure
d25b037 
Tested locally with a test purposely broken.

Fixes: d3dd7e8 ("test: Move Bookinfo Demo to a separate test suite")
Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno force-pushed the bookinfo-test-collect-full-artifact branch from ef8c99e to d25b037 Compare July 5, 2021 09:34
qmonnet
qmonnet approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but note that the commit it fixes has a backport pending for 1.10, so it's probably worth marking this one as well?

@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.3 Jul 7, 2021
@pchaigno
Copy link
Member Author

pchaigno commented Jul 7, 2021

All team review requests are covered and the new code compiles. Marking as ready to merge and merging.

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 7, 2021
@pchaigno pchaigno merged commit 3628e69 into cilium:master Jul 7, 2021
@pchaigno pchaigno deleted the bookinfo-test-collect-full-artifact branch July 7, 2021 12:52
This was referenced Jul 7, 2021
Closed
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.10.3 Jul 8, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.10 in 1.10.3 Jul 15, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.10 in 1.10.3 Jul 15, 2021
@aanm aanm mentioned this pull request Jul 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@nebril nebril nebril approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake kind/bug/CI This is a bug in the testing code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.10.3
Backport done to v1.10
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pchaigno @joestringer @nebril @qmonnet @aanm