Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: ignore __pycache__ directory created by custom spelling filters #16791

Merged
merged 1 commit into from Jul 7, 2021

Conversation

qmonnet
Copy link
Member

@qmonnet qmonnet commented Jul 5, 2021

We recently added a custom filter for spell checking, in order to have better control on the case for some specific terms. This custom filter is written as a Python function in a dedicated file, and it turns out that this file is pre-compiled when building the documentation. Let's add the relevant __pycache__ directory to the .gitignore in the documentation directory.

Fixes: 8710477 ("docs: add custom spelling filter to check WireGuard spelling")
Fixes: #16513

We recently added a custom filter for spell checking, in order to have
better control on the case for some specific terms. This custom filter
is written as a Python function in a dedicated file, and it turns out
that this file is pre-compiled when building the documentation. Let's
add the relevant __pycache__ directory to the .gitignore in the
documentation directory.

Fixes: 8710477 ("docs: add custom spelling filter to check WireGuard spelling")
Fixes: cilium#16513

Signed-off-by: Quentin Monnet <quentin@isovalent.com>
@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Jul 5, 2021
@qmonnet qmonnet requested a review from a team as a code owner July 5, 2021 16:25
@qmonnet qmonnet requested a review from joestringer July 5, 2021 16:25
@joestringer joestringer merged commit 577030c into cilium:master Jul 7, 2021
@qmonnet qmonnet deleted the pr/doc-ext-pycache-ignore branch July 8, 2021 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants