New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test/bpf: Flag to continue in case of errors #16793
test/bpf: Flag to continue in case of errors #16793
Conversation
96b9313
to
8e77717
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just a minor nit, feel free to ignore it.
FORCE seems somewhat confusing to me. -c|--continue
or -i|-ignoreerr
maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aside from @kkourt feedback lgtm (maybe --skip-errors as flag name)
8e77717
to
0393bf8
Compare
I switched to |
This commit adds a new flag --force to instruct verifier-test.sh to ignore errors when failing to load a program and continue with subsequent programs. That enables us to get a full picture of the complexity reported by the verifier, even if one of the programs fails. Signed-off-by: Paul Chaignon <paul@cilium.io>
Signed-off-by: Paul Chaignon <paul@cilium.io>
0393bf8
to
dfb4224
Compare
This pull request adds a new flag
--force
to instructverifier-test.sh
to ignore errors when failing to load a program and continue with subsequent programs. That enables us to get a full picture of the complexity reported by the verifier, even if one of the programs fails.