Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/bpf: Flag to continue in case of errors #16793

Merged
merged 2 commits into from Aug 2, 2021

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Jul 5, 2021

This pull request adds a new flag --force to instruct verifier-test.sh to ignore errors when failing to load a program and continue with subsequent programs. That enables us to get a full picture of the complexity reported by the verifier, even if one of the programs fails.

@pchaigno pchaigno added area/CI Continuous Integration testing issue or flake release-note/misc This PR makes changes that have no direct user impact. kind/complexity-issue Relates to BPF complexity or program size issues labels Jul 5, 2021
@pchaigno pchaigno force-pushed the verifier-test-ignore-errors branch from 96b9313 to 8e77717 Compare July 7, 2021 13:39
@pchaigno pchaigno marked this pull request as ready for review July 7, 2021 18:54
@pchaigno pchaigno requested a review from a team as a code owner July 7, 2021 18:54
@pchaigno pchaigno requested a review from borkmann July 7, 2021 18:54
Copy link
Contributor

@kkourt kkourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just a minor nit, feel free to ignore it.
FORCE seems somewhat confusing to me. -c|--continue or -i|-ignoreerr maybe?

Copy link
Member

@borkmann borkmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside from @kkourt feedback lgtm (maybe --skip-errors as flag name)

@pchaigno
Copy link
Member Author

I switched to --skip-errors and removed the shortcut (it's not like we use that script so often that it's crucial).

@pchaigno pchaigno marked this pull request as draft July 14, 2021 18:02
This commit adds a new flag --force to instruct verifier-test.sh to
ignore errors when failing to load a program and continue with
subsequent programs. That enables us to get a full picture of the
complexity reported by the verifier, even if one of the programs fails.

Signed-off-by: Paul Chaignon <paul@cilium.io>
Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno force-pushed the verifier-test-ignore-errors branch from 0393bf8 to dfb4224 Compare July 26, 2021 15:54
@pchaigno pchaigno marked this pull request as ready for review July 26, 2021 15:54
@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 28, 2021
@pchaigno pchaigno changed the title test/bpf: Flag to continue in case of errors. test/bpf: Flag to continue in case of errors Jul 28, 2021
@nathanjsweet nathanjsweet merged commit 088f465 into cilium:master Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake kind/complexity-issue Relates to BPF complexity or program size issues ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants