test: Fix local runs of K8sUpdates #16802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
kind/bug/CI
pchaigno
force-pushed
the
fix-local-run-k8supdates
branch
from
ea7f372
to
a894ea9
Compare
pchaigno
force-pushed
the
fix-local-run-k8supdates
branch
from
a894ea9
to
4a7276a
Compare
When run locally with the default arguments, K8sUpdates fails because the cilium-operator image for downgrades is downloaded at quay.io/cilium/operator-generic instead of quay.io/cilium/operator-generic-ci. Unfortunately, passing cilium.operator-suffix="-ci" as an argument to ginkgo is not enough because, for local test runs, the image is pushed to k8s1:5000/cilium/operator-generic. This commit fixes those issues and makes "-ci" the default value of cilium.operator-suffix. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
fix-local-run-k8supdates
branch
from
4a7276a
to
9e7d13b
Compare
|
test-me-please |
tklauser
approved these changes
Jul 14, 2021
pchaigno
added
the
ready-to-merge
nebril
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When run locally with the default arguments, K8sUpdates fails because the cilium-operator image for downgrades is downloaded at
quay.io/cilium/operator-genericinstead ofquay.io/cilium/operator-generic-ci. Unfortunately, passingcilium.operator-suffix="-ci"as an argument to ginkgo is not enough because, for local test runs, the image is pushed tok8s1:5000/cilium/operator-generic.This pull request fixes those issues and makes
-cithe default value ofcilium.operator-suffix.