test: Fix helper to retrieve tail call counters #16803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
kind/bug/CI
pchaigno
force-pushed
the
fix-test-incorrect-tail-call-counter
branch
from
39d799b
to
dcc4316
Compare
If the tail call counter was zero (absent) on the first node, the helper function would simply return as if it was absent on all nodes. This commit fixes that bug. Fixes: e9b3844 ("test: Detect missed tail calls on upgrade/downgrade test") Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
fix-test-incorrect-tail-call-counter
branch
from
dcc4316
to
f1092bc
Compare
|
test-me-please |
tklauser
approved these changes
Jul 14, 2021
pchaigno
added
the
ready-to-merge
nebril
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the tail call counter was zero (absent) on the first node, the helper function would simply return as if it was absent on all nodes. This pull request fixes that bug.
Fixes: #13097.