Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpf/pcap: Use CAPTURE{4,6}_RULES macros #16809

Merged
merged 1 commit into from Jul 6, 2021

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Jul 6, 2021

The CAPTURE{4,6}_RULES macros are defined but not used in the code.

Fixes: #15376.

The CAPTURE{4,6}_RULES macros are defined but not used in the code.

Fixes: 9c47695 ("cilium: add wildcarded capture map representation")
Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Jul 6, 2021
@pchaigno pchaigno requested review from borkmann and a team July 6, 2021 14:18
Copy link
Member

@borkmann borkmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pchaigno
Copy link
Member Author

pchaigno commented Jul 6, 2021

There are no end-to-end tests for this datapath code, so nothing to trigger. All initial tests are passing and the team review request is covered. Merging.

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 6, 2021
@pchaigno pchaigno merged commit 11145cd into cilium:master Jul 6, 2021
@pchaigno pchaigno deleted the fix-map-name-constants branch July 6, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants