choir: normalize error handling in kube_proxy_replacement.go #16811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
|
will be more of these per our discussion on normalizing the error handling for depedencies in NewDaemon. |
ldelossa
force-pushed
the
louis/normalize-err-handling
branch
from
a1d4d7b
to
2f12813
Compare
joestringer
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
joestringer
requested changes
Jul 6, 2021
christarazi
reviewed
Jul 6, 2021
ldelossa
force-pushed
the
louis/normalize-err-handling
branch
from
2f12813
to
c86c3f3
Compare
|
@christarazi @joestringer |
christarazi
reviewed
Jul 6, 2021
joestringer
approved these changes
Jul 7, 2021
ldelossa
force-pushed
the
louis/normalize-err-handling
branch
from
c86c3f3
to
6ff6618
Compare
|
@christarazi @joestringer sorry about that bit of confusion, that nodediscovery.go file was not supposed to be in this PR at all. Removed it from the edited set and force pushed. |
christarazi
approved these changes
Jul 7, 2021
aanm
approved these changes
Jul 8, 2021
| @@ -41,12 +41,12 @@ import ( | |||
| "golang.org/x/sys/unix" | |||
| ) | |||
|
|
|||
| func initKubeProxyReplacementOptions() (strict bool) { | |||
| func initKubeProxyReplacementOptions() (bool, error) { | |||
There was a problem hiding this comment.
hint to leave a comment about the returned values since now we don't know what is bool used for.
There was a problem hiding this comment.
@aanm I updated this function with a comment describing its usage, can you please read this comment and ensure I have its usage summarized correctly.
this commit normalizes the error handling in kube_proxy_replacement.go by bubbling errors up to the caller of the initialization method. Signed-off-by: Louis DeLosSantos <louis.delos@isovalent.com>
ldelossa
force-pushed
the
louis/normalize-err-handling
branch
from
6ff6618
to
16c502a
Compare
aanm
approved these changes
Jul 8, 2021
ldelossa
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit normalizes the error handling in kube_proxy_replacement.go
by bubbling errors up to the caller of the initialization method.
Signed-off-by: Louis DeLosSantos louis.delos@isovalent.com