Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for platforms where init container fails to run #16815

Merged
merged 3 commits into from
Jul 8, 2021
Merged

Fixes for platforms where init container fails to run #16815

merged 3 commits into from
Jul 8, 2021

Conversation

aditighag
Copy link
Member

@aditighag aditighag commented Jul 7, 2021 •
edited
Loading

See commit messages.

Fixes: #16814 / #16828
Fixes: #16771
Fixes: fa8bea4 ("cilium-daemonset: Fix ineffective socket-lb caused by incorrect cgroup2 fs mount")

Release note

Removes cilium daemonset's dependencies on utilities like `sh` and `mount` having installed in the underlying host distributions.

@aditighag aditighag requested review from a team as code owners July 7, 2021 01:12
@aditighag aditighag requested a review from a team July 7, 2021 01:12
@aditighag aditighag added the release-note/bug This PR fixes an issue in a previous release of Cilium. label Jul 7, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jul 7, 2021
@aditighag aditighag requested a review from aanm July 7, 2021 01:12
@aditighag
Copy link
Member Author

test-me-please

aanm
aanm requested changes Jul 7, 2021
View reviewed changes
install/kubernetes/cilium/templates/cilium-agent-daemonset.yaml Show resolved Hide resolved
mount/main.go Outdated Show resolved Hide resolved
mount/main.go Outdated Show resolved Hide resolved
@aanm aanm added kind/regression This functionality worked fine before, but was broken in a newer release of Cilium. needs-backport/1.10 labels Jul 7, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.3 Jul 7, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.9.9 Jul 7, 2021
@aditighag
Copy link
Member Author

aditighag commented Jul 7, 2021 •
edited
Loading

Looking into the conformance-test-ipv6 failure - resolved the issue.

@aditighag
Copy link
Member Author

test-me-please

aditighag
aditighag commented Jul 7, 2021
View reviewed changes
mount/main.go Outdated Show resolved Hide resolved
@aditighag
Copy link
Member Author

AKS failure -

ERROR: Deployment failed. Correlation ID: 3b2691d4-fb4d-439f-9a68-b9d543d65365. Resource request failed due to RequestDisallowedByPolicy. Please see https://aka.ms/aks-requestdisallowedbypolicy for more details. The detailed error message: ResourceGroupReconciler retry failed: Category: ClientError; SubCode: RequestDisallowedByPolicy; Dependency: Azure Resource Manager; OrginalError: Code="RequestDisallowedByPolicy" Message="Resource 'MC_cilium-cilium-1006785919_cilium-cilium-1006785919_westeurope' was disallowed by policy. Reasons: '"owner=$PR_ID" tag required, to identify which PR these resources belong to.'. See error details for policy resource IDs." Target="MC_cilium-cilium-1006785919_cilium-cilium-1006785919_westeurope" AdditionalInfo=["info":"evaluationDetails":***"evaluatedExpressions":

AWS-CNI failure -

📋 Test Report
❌ 1/9 tests failed (1/81 actions), 0 warnings, 0 tests skipped, 0 scenarios skipped:
Test [to-fqdns]:
❌ to-fqdns/pod-to-world/http-to-cilium-io: cilium-test/client-7b7bf54b85-nxdlg (192.168.109.217) -> cilium-io-http (cilium.io:80)

aanm
aanm requested changes Jul 7, 2021
View reviewed changes
mount/main.go Outdated Show resolved Hide resolved
mount/main.go Outdated Show resolved Hide resolved
@aditighag aditighag added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 8, 2021
@aditighag aditighag merged commit a76bbde into cilium:master Jul 8, 2021
@aditighag aditighag deleted the pr/aditighag/remove-sh-dep branch July 9, 2021 16:28
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.10.3 Jul 9, 2021
@joestringer joestringer mentioned this pull request Jul 9, 2021
Merged
@aanm aanm added this to Backport pending to v1.10 in 1.10.4 Jul 15, 2021
@aanm aanm removed this from Backport pending to v1.10 in 1.10.3 Jul 15, 2021
@aanm aanm mentioned this pull request Jul 15, 2021
Merged
@aditighag aditighag mentioned this pull request Jul 15, 2021
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.9 in 1.9.9 Jul 15, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.9 to Backport done to v1.9 in 1.9.9 Jul 15, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.9 to Backport done to v1.9 in 1.9.9 Jul 15, 2021
@joestringer joestringer mentioned this pull request Jul 19, 2021
Merged
@joestringer joestringer removed this from Backport pending to v1.10 in 1.10.4 Sep 1, 2021
@aanm aanm mentioned this pull request Nov 16, 2021
Closed
aditighag added a commit to aditighag/cilium-cli that referenced this pull request Nov 24, 2021
@aditighag
install: Mount cgroup2 filesystem from init container on host
dd5af0b 
We need to mount cgroup2 filesystem on the underlying host
in order to enable socket-based load-balancing in environments
with container runtime cgroupv2 configurations.

See issues for more details - cilium/cilium#16259
and cilium/cilium#16815.
@aditighag aditighag mentioned this pull request Nov 24, 2021
Draft
aditighag added a commit to aditighag/cilium-cli that referenced this pull request Nov 24, 2021
@aditighag
install: Add init container to mount cgroup2 filesystem
10cff1d 
We need to mount cgroup2 filesystem on the underlying host
in order to enable socket-based load-balancing in environments
with container runtime cgroupv2 configurations.

See issues for more details - cilium/cilium#16259
and cilium/cilium#16815.

Signed-off-by: Aditi Ghag <aditi@cilium.io>
@qmonnet
Copy link
Member

qmonnet commented Nov 26, 2021

Checking the ongoing backports, I see that this PR is labelled as backport-pending/1.10, but I can't find the relevant PR. @aditighag can you please double-check that the corresponding backport PR exists / is tagged appropriately / references this one, or whether we skipped it?

@ernado ernado mentioned this pull request Nov 27, 2021
Closed
@aditighag
Copy link
Member Author

@qmonnet The PR is already backported to v1.10. I updated the label. Thanks for checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkourt kkourt kkourt approved these changes

@joestringer joestringer joestringer approved these changes

@aanm aanm aanm approved these changes

@errordeveloper errordeveloper Awaiting requested review from errordeveloper

Assignees

@errordeveloper errordeveloper

Labels
kind/regression This functionality worked fine before, but was broken in a newer release of Cilium. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
No open projects
1.9.9
Backport done to v1.9
Milestone
No milestone
6 participants
@aditighag @qmonnet @kkourt @joestringer @aanm @errordeveloper