iptables: Remove leading zeroes #16817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove leading zeroes from marks, as 'iptables' is not formatting them. This allows proper matching of existing rules and avoids appending duplicate rules. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
jrajahalme
added
kind/bug
|
test-me-please |
pchaigno
approved these changes
Jul 7, 2021
joestringer
approved these changes
Jul 7, 2021
aanm
added
the
kind/regression
pchaigno
added
the
dont-merge/needs-rebase
|
This PR needs to be rebased to catch #16767. |
borkmann
approved these changes
Jul 12, 2021
|
known flake #14598 in test-1.21-4.9 |
|
None of the test fails are due to this PR, and this PR being a regression fix I'll mark this ready-to-merge without further re-testing. |
jrajahalme
added
the
ready-to-merge
In that case, shouldn't the release-note label say "bug"? |
|
Merging this, since the |
pchaigno
removed
the
release-note/misc
pchaigno
added
the
release-note/bug
jrajahalme
removed
dont-merge/needs-rebase
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport done to v1.10
in 1.10.3
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport done to v1.10
in 1.10.3
joestringer
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.10
joestringer
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.11
|
@jrajahalme I believe that the backports were already done for this PR for both v1.9 and v1.8, can you confirm? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove leading zeroes from marks, as 'iptables' is not formatting
them. This allows proper matching of existing rules and avoids
appending duplicate rules.
Backports of the iptables change in #16391 for 1.9 and 1.8 already contain this fix.
Fixes: #16391
Signed-off-by: Jarno Rajahalme jarno@isovalent.com