Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github: Increase workflow timeout #16819

Merged
merged 1 commit into from Jul 13, 2021
Merged

github: Increase workflow timeout #16819

merged 1 commit into from Jul 13, 2021

Conversation

jrajahalme
Copy link
Member

Increase conformance-gke timeout to avoid fail due to cancelled test
as in:

installation-and-connectivity
cancelled 2 hours ago in 30m 13s

[=] Test [client-egress]
....
[=] Test [echo-ingress]
Error: The operation was canceled.

Signed-off-by: Jarno Rajahalme jarno@isovalent.com

@jrajahalme jrajahalme added kind/bug/CI This is a bug in the testing code. area/CI Continuous Integration testing issue or flake release-note/misc This PR makes changes that have no direct user impact. labels Jul 7, 2021
@jrajahalme jrajahalme requested review from a team as code owners July 7, 2021 14:39
@jrajahalme jrajahalme requested review from nebril and aanm July 7, 2021 14:39
@jrajahalme
Copy link
Member Author

ci-gke

aanm
aanm approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@aanm aanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrajahalme do you have any idea why the connectivity tests are taking so much time? A run from 12 days ago, the connectivity test took 8 mins for the first run and ~3 minutes for the next ones.

@jrajahalme
Copy link
Member Author

@aanm First connectivity test taking longer is most likely due to the various prechecks before running actual tests. Prechecks wait that the deployments are available, ipcache's are coherent, and that service backends are available via DNS. On futher runs these checks would pass without delays.

@jrajahalme
Copy link
Member Author

ci-gke hit the same 30 minute timeout this PR should fix. Will test by enabling the pull_request in the workflow.

@jrajahalme
github: Increase workflow timeout
15fdf08 
Increase conformance-gke timeout to avoid fail due to cancelled test
as in:

installation-and-connectivity
cancelled 2 hours ago in 30m 13s


[=] Test [client-egress]
....
[=] Test [echo-ingress]
Error: The operation was canceled.

Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
@jrajahalme jrajahalme force-pushed the pr/jrajahalme/github-workflow-timeout-increase branch from e3cde1f to 8da2e44 Compare July 9, 2021 06:02
@jrajahalme
Copy link
Member Author

ci-gke

@jrajahalme jrajahalme added the dont-merge/preview-only Only for preview or testing, don't merge it. label Jul 9, 2021
@jrajahalme jrajahalme mentioned this pull request Jul 9, 2021
Merged
@jrajahalme jrajahalme added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. and removed dont-merge/preview-only Only for preview or testing, don't merge it. labels Jul 12, 2021
@nebril nebril removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 12, 2021
nebril
nebril requested changes Jul 12, 2021
View reviewed changes
Copy link
Member

@nebril nebril left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please remove pull_request trigger from workflow before merging

.github/workflows/conformance-gke.yaml Outdated
@@ -20,7 +20,7 @@ on:
# will disappear from the PR checks: please provide a direct link to the
# successful workflow run (can be found from Actions tab) in a comment.
#
# pull_request: {}
pull_request: {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please comment out before merging

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed, thanks for the remainder :-)

@jrajahalme jrajahalme force-pushed the pr/jrajahalme/github-workflow-timeout-increase branch from 8da2e44 to 15fdf08 Compare July 12, 2021 13:02
@jrajahalme jrajahalme added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 12, 2021
@jrajahalme jrajahalme mentioned this pull request Jul 12, 2021
Closed
@kkourt kkourt merged commit 72ba43d into master Jul 13, 2021
@kkourt kkourt deleted the pr/jrajahalme/github-workflow-timeout-increase branch July 13, 2021 08:18
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.3 Jul 14, 2021
@aanm aanm mentioned this pull request Jul 14, 2021
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport done to v1.10 in 1.10.3 Jul 15, 2021
@aanm aanm mentioned this pull request Jul 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebril nebril nebril requested changes

@tklauser tklauser tklauser approved these changes

@aanm aanm aanm approved these changes

Assignees

@nebril nebril

Labels
area/CI Continuous Integration testing issue or flake kind/bug/CI This is a bug in the testing code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.3
Backport done to v1.10
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jrajahalme @tklauser @nebril @aanm @kkourt