New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflows: fix L4LB test missing PR reporting on issue_comment #16830
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Unlike `pull_request`-triggered runs, `issue_comment`-triggered runs cannot automatically report back to the PR they were triggered from. Adding manual reporting as per the other workflows. Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
L4LB test failed: https://github.com/cilium/cilium/actions/runs/1012162379
The manual PR check did get added properly to the PR: Removing temp commit. |
e492016
to
c580397
Compare
Btw I see this note in the workflow yaml [1] -
Edit : Nvm, saw this comment - #16830 (comment). [1] https://github.com/cilium/cilium/blob/master/.github/workflows/tests-l4lb.yaml |
@nbusseneau @brb Does this GH action need to be run as a cron job if it's run on ever PR? |
It's there for testing |
Unlike
pull_request
-triggered runs,issue_comment
-triggered runs cannot automatically report back to the PR they were triggered from.Adding manual reporting as per the other workflows.