workflows: fix Relay pgrep check when using additional flags #16831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbusseneau
added
area/CI
tklauser
approved these changes
Jul 8, 2021
|
Multicluster test passed: https://github.com/cilium/cilium/actions/runs/1012204661 |
nbusseneau
force-pushed
the
pr/workflow-fix-multicluster-relay
branch
from
e2ecaf8
to
9bde742
Compare
michi-covalent
approved these changes
Jul 8, 2021
When passing additional flags to `cilium hubble port-forward`, both the original command and `kubectl` child process might be conflated with additional flags. We add wildcards for matching the additional flags to both `pkill` cleanups and `pgrep` port-forward success checks. Fixes 00ae9fb Follow-up to #16787 Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
nbusseneau
force-pushed
the
pr/workflow-fix-multicluster-relay
branch
from
9bde742
to
c4e66de
Compare
joestringer
approved these changes
Jul 8, 2021
nbusseneau
added
the
ready-to-merge
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.3
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Needs backport from master
in 1.10.3
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.3
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.3
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.10
in 1.10.3
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.10
in 1.10.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing additional flags to
cilium hubble port-forward, both the original command andkubectlchild process might be conflated with additional flags.We add wildcards for matching the additional flags.
Fixes 00ae9fb
Follow-up to #16787