.github: do not useDigest in conformance tests #16836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanm
added
release-note/misc
aanm
commented
Jul 9, 2021
Conformance tests are executed against the code being submitted in a PR. If `useDigest` is set to true it will use the default digest defined in the helm charts, which in stable branches is the last stable release. Fixes: 41f66a1 (".github: use quay.io images in smoke tests") Signed-off-by: André Martins <andre@cilium.io>
aanm
force-pushed
the
pr/fix-conformance-tests
branch
from
097c6e7
to
9e7d54f
Compare
christarazi
approved these changes
Jul 9, 2021
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport done to v1.10
in 1.10.3
aanm
added
release-note/ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conformance tests are executed against the code being submitted in a PR.
If
useDigestis set to true it will use the default digest defined inthe helm charts, which in stable branches is the last stable release.
Fixes: 41f66a1 (".github: use quay.io images in smoke tests")
Signed-off-by: André Martins andre@cilium.io
Note for reviewers: <1.10 branches are not affected since
useDigestwas only set totrueby default in 1.10