chore: normalize returning of errors in NewDaemon #16861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joestringer
reviewed
Jul 12, 2021
ldelossa
force-pushed
the
louis/normalize-err-handling
branch
from
a7bb5ab
to
d0ad10a
Compare
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
joestringer
approved these changes
Jul 13, 2021
|
test-me-please |
ldelossa
changed the title
jibi
approved these changes
Jul 13, 2021
ldelossa
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
christarazi
reviewed
Jul 13, 2021
There was a problem hiding this comment.
Changes look good to me. Should we be applying https://github.com/golang/go/wiki/CodeReviewComments#error-strings to the error messages as well?
|
@christarazi I'm not opposed to standardizing our error message handling by that, as long as we maintain consistency it looks like a good ruler for us to use. |
ldelossa
force-pushed
the
louis/normalize-err-handling
branch
from
d0ad10a
to
39575e9
Compare
|
@christarazi I pre-emptively pushed a commit with all the errors conforming to the prose you provided. If any others don't like this style, feel free to debate it here, I can easily back out the change. |
|
test-me-please |
house-keeping PR to ensure similar behavior in the NewDaemon method. After this commit all error conditions are returned if the intent is to fatal the process. Signed-off-by: Louis DeLosSantos <louis.delos@isovalent.com>
ldelossa
force-pushed
the
louis/normalize-err-handling
branch
from
39575e9
to
b930eb7
Compare
|
test-me-please |
ldelossa
added
the
ready-to-merge
ldelossa
added a commit
to ldelossa/cilium
that referenced
this pull request
Mar 30, 2022
commit cilium#16861 introduced a normalization of error handling into the daemon/cmd package. by doing so we swallowed useful error logs. this commit adds the error logs back and adds a few additional fmt.Errorf wrappers where logging is not adequate Signed-off-by: Louis DeLosSantos <louis.delos@isovalent.com>
joestringer
pushed a commit
that referenced
this pull request
Apr 30, 2022
commit #16861 introduced a normalization of error handling into the daemon/cmd package. by doing so we swallowed useful error logs. this commit adds the error logs back and adds a few additional fmt.Errorf wrappers where logging is not adequate Signed-off-by: Louis DeLosSantos <louis.delos@isovalent.com>
aditighag
pushed a commit
to aditighag/cilium
that referenced
this pull request
May 2, 2022
[ upstream commit 6154322 ] commit cilium#16861 introduced a normalization of error handling into the daemon/cmd package. by doing so we swallowed useful error logs. this commit adds the error logs back and adds a few additional fmt.Errorf wrappers where logging is not adequate Signed-off-by: Louis DeLosSantos <louis.delos@isovalent.com> Signed-off-by: Aditi Ghag <aditi@cilium.io>
aditighag
pushed a commit
that referenced
this pull request
May 3, 2022
[ upstream commit 6154322 ] commit #16861 introduced a normalization of error handling into the daemon/cmd package. by doing so we swallowed useful error logs. this commit adds the error logs back and adds a few additional fmt.Errorf wrappers where logging is not adequate Signed-off-by: Louis DeLosSantos <louis.delos@isovalent.com> Signed-off-by: Aditi Ghag <aditi@cilium.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
house-keeping PR to ensure similar behavior in the NewDaemon method.
After this commit all error conditions are returned if the intent is to
fatal the process.
Signed-off-by: Louis DeLosSantos louis.delos@isovalent.com