test: Debug kubectl.GetPrivateIface failure
#16863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If GetPrivateIface returns an empty string, we currently proceed as usual and eventually fail later during the test itself, with few information available to debug. This commit changes that to fail early in GetPrivateIface if the returned interface name is empty. In that case, the output of ip a is also returned. Signed-off-by: Paul Chaignon <paul@cilium.io>
This reverts commit 12a4a48. That commit printed the outputs of ip a and ip r in case of failure in the IPsec test. That was done in an effort to debug a failure in the IPsec interface detection. It however appears that that failure is expected in the test VM (because of our weird enp0s3 & enp0s8 setup) and the interface detection shouldn't run in the first place. Instead, we explicitly set the IPsec interface when deploying Cilium. In some rare cases, setting this Cilium flag fails (see previous commit) and we fallback to the interface detection. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added
area/CI
|
test-me-please |
tklauser
approved these changes
Jul 13, 2021
|
k8s-1.21-kernel-4.9 (test-1.21-4.9) failed with #16717 (this PR doesn't have the latest fix which was merged just 5min ago). Other tests are passing and the team review requests are covered. Marking as ready to merge. |
pchaigno
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for details.
Related: #16699.