workflows: Skip FQDN tests in AWS-CNI workflow #16868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit d78968e (".github: AWS-CNI end-to-end test") skipped the FQDN test in cilium connectivity test for the AWS-CNI workflow because L7 policies aren't supported in chaining mode. That test was skipped using: cilium connectivity test --test '!pod-to-world-toFQDNs' However, in commit d9eff9a ("ci: Bump cilium-cli version") the cilium-cli version was updated from v0.6 to v0.8.1. In between those version the name of the FQDN test changed (to "to-fqdns"). This commit therefore updates the filter expression to filter all test with FQDN in their name: cilium connectivity test --test '!fqdn' I tested the above correctly skips the "to-fqdns" test locally with a GKE cluster. Fixes: d9eff9a ("ci: Bump cilium-cli version") Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added
kind/bug/CI
pchaigno
added
the
ready-to-merge
aanm
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit d78968e (".github: AWS-CNI end-to-end test") skipped the FQDN test in cilium connectivity test for the AWS-CNI workflow because L7 policies aren't supported in chaining mode. That test was skipped using:
However, in commit d9eff9a ("ci: Bump cilium-cli version") the cilium-cli version was updated from v0.6 to v0.8.1. In between those version the name of the FQDN test changed (to
to-fqdns). This commit therefore updates the filter expression to filter all test with FQDN in their name:I tested the above correctly skips the
to-fqdnstest locally with a GKE cluster.Fixes: #16617.