test/K8sBookInfo: Readiness probes for test pods #16869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test pods used in the k8sBookInfo test did not have readiness probe. Therefore, from time to time, the pods would be marked as Ready before their application was listening on the server's port. The subsequent connectivity check would thus fail with a TCP RST. This commit fixes that issue by defining a proper readiness probe for all pods used in K8sBookInfo, such that the test will only proceed once the application is ready to serve requests. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added
kind/bug/CI
|
test-me-please |
|
k8s-1.19-kernel-5.4 failed with known flake #16852. Reviews are in. Given this is fixing another flake, we can merge despite the failure. Marking as ready to merge. |
pchaigno
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test pods used in the k8sBookInfo test did not have readiness probe. Therefore, from time to time, the pods would be marked as Ready before their application was listening on the server's port. The subsequent connectivity check would thus fail with a TCP RST.
This commit fixes that issue by defining a proper readiness probe for all pods used in K8sBookInfo, such that the test will only proceed once the application is ready to serve requests.
Fixes: #16632.