Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix code-block formatting for XDP load example #16876

Merged
merged 1 commit into from Jul 15, 2021
Merged

docs: fix code-block formatting for XDP load example #16876

merged 1 commit into from Jul 15, 2021

Conversation

claudiajkang
Copy link
Contributor

On load XDP BPF example section at "BPF and XDP Reference Guide"
there are minor formatting issues related to code-block.
Thus, this commit fixes these minor formatting issues.

2

Signed-off-by: Claudia J. Kang claudiajkang@gmail.com

@claudiajkang
docs, bpf: fix code-block for load XDP BPF example
518b121 
On load XDP BPF example section at "BPF and XDP Reference Guide"
there are minor formatting issues related to code-block.
Thus, this commit fixes these minor formatting issues.

Signed-off-by: Claudia J. Kang <claudiajkang@gmail.com>
@claudiajkang claudiajkang requested a review from a team July 14, 2021 12:22
@claudiajkang claudiajkang requested a review from a team as a code owner July 14, 2021 12:22
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 14, 2021
@qmonnet qmonnet changed the title docs, bpf: fix code-block for load XDP BPF example docs: fix code-block formatting for XDP load example Jul 14, 2021
@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. needs-backport/1.10 release-note/misc This PR makes changes that have no direct user impact. labels Jul 14, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 14, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.3 Jul 14, 2021
qmonnet
qmonnet approved these changes Jul 14, 2021
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you for the fix!

@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 14, 2021
@nebril nebril merged commit fae9f96 into cilium:master Jul 15, 2021
@aanm aanm added this to Needs backport from master in 1.10.4 Jul 15, 2021
@aanm aanm removed this from Needs backport from master in 1.10.3 Jul 15, 2021
@aanm aanm mentioned this pull request Jul 21, 2021
Merged
@joestringer joestringer moved this from Needs backport from master to Backport done to v1.10 in 1.10.4 Sep 1, 2021
@joestringer joestringer mentioned this pull request Sep 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet approved these changes

@jrfastab jrfastab Awaiting requested review from jrfastab

Assignees

@jrfastab jrfastab

Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.4
Backport done to v1.10
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@claudiajkang @qmonnet @joestringer @jrfastab @nebril @aanm