daemon: make consecutive quorum errors threshold configurable #16885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
ArthurChiao
force-pushed
the
make_quorum_threshold_configurable
branch
from
250a569
to
dd475d9
Compare
tklauser
reviewed
Jul 19, 2021
ArthurChiao
force-pushed
the
make_quorum_threshold_configurable
branch
3 times, most recently
from
265f9d6
to
d324ad3
Compare
ArthurChiao
force-pushed
the
make_quorum_threshold_configurable
branch
from
d324ad3
to
24a77b7
Compare
On detecting heartbeat (written by cilium-operator) missing from kvstore with consecutive probes, the clustermesh module in cilium-agent will re-connect kvstore. For large clusters/meshes, e.g. clusters with thousands of nodes, the concurrent reconnecting and list+watching behaviors pose significant pressue on kvstore, to the extent of crashing it. The threshold is currently hardcoded as 2, and this patch makes it configurable, which gives users a chance to choose from fast failure, or being more patient on encountering kvstore/operator/k8s-control-plane problems. Signed-off-by: ArthurChiao <arthurchiao@hotmail.com>
ArthurChiao
force-pushed
the
make_quorum_threshold_configurable
branch
from
24a77b7
to
8979e92
Compare
errordeveloper
approved these changes
Jul 19, 2021
joestringer
approved these changes
Jul 19, 2021
joestringer
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
tklauser
approved these changes
Jul 19, 2021
borkmann
approved these changes
Aug 2, 2021
borkmann
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On detecting heartbeat (written by cilium-operator) missing from kvstore
with consecutive probes, the clustermesh module in cilium-agent will
re-connect kvstore. For large clusters/meshes, e.g. clusters with
thousands of nodes, the concurrent reconnecting and list+watching
behaviors pose significant pressue on kvstore, to the extent of crashing
it.
The threshold is currently hardcoded as 2, and this patch makes it
configurable, which gives users a chance to choose from fast failure, or
being more patient on encountering kvstore/operator/k8s-control-plane
problems.
Signed-off-by: ArthurChiao arthurchiao@hotmail.com