test: do not useDigest in upstream tests #16886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream tests should be executed against the code being submitted in a PR. If `useDigest` is set to true it will use the default digest defined in the helm charts, which in stable branches is the last stable release and not the code being submitted in a PR. Fixes: 41f66a1 (".github: use quay.io images in smoke tests") Signed-off-by: André Martins <andre@cilium.io>
aanm
added
kind/bug
|
test-upstream-k8s |
aditighag
approved these changes
Jul 14, 2021
|
I think there is one more - https://github.com/cilium/cilium/blob/master/test/l4lb/test.sh#L34? I'm not sure if you want to send another PR for that. |
pchaigno
approved these changes
Jul 14, 2021
|
test-upstream-k8s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream tests should be executed against the code being submitted
in a PR. If
useDigestis set to true it will use the default digestdefined in the helm charts, which in stable branches is the last
stable release and not the code being submitted in a PR.
Fixes: 41f66a1 (".github: use quay.io images in smoke tests")
Signed-off-by: André Martins andre@cilium.io