Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alias of cilium-health get #16891

Merged
merged 1 commit into from Jul 22, 2021
Merged

Fix alias of cilium-health get #16891

merged 1 commit into from Jul 22, 2021

Conversation

xyz-li
Copy link
Contributor

@xyz-li xyz-li commented Jul 15, 2021

Currently, the alias of cilium-health get is cilium-health "inspect, show", not cilium-health inspect or cilium-health show.

/cc @joestringer

@xyz-li xyz-li requested a review from a team as a code owner July 15, 2021 03:00
@xyz-li xyz-li requested a review from a team July 15, 2021 03:00
@maintainer-s-little-helper
Copy link

Commit 5f5690dc1a495055eef3fd3fedb320ba085d52a1 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jul 15, 2021
@maintainer-s-little-helper
Copy link

Commit 5f5690dc1a495055eef3fd3fedb320ba085d52a1 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Jul 15, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 15, 2021
@joestringer
Copy link
Member

Looks good, thanks for the fix. Just need your sign-off on the commit like the bot is saying above.

@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jul 16, 2021
@xyz-li xyz-li force-pushed the master branch 2 times, most recently from 1b1879a to 8730838 Compare July 17, 2021 08:01
Signed-off-by: LiHui <andrewli@yunify.com>
@xyz-li
Copy link
Contributor Author

xyz-li commented Jul 21, 2021

@cilium/health
@cilium/cli

@joestringer
Copy link
Member

Sanity checks passed, no need to run full integration tests for such a change. Good to merge.

@joestringer joestringer merged commit ae37b03 into cilium:master Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants