test: Remove Services SCTP test case #16895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brb
added
area/CI
brb
force-pushed
the
pr/brb/disable-sctp-tests
branch
2 times, most recently
from
0d61fa0
to
367c22d
Compare
|
test-1.16-netnext |
|
net-next hit #12511. Considering that the test removal doesn't have anything to do with it, no need to re-run tests. |
tklauser
approved these changes
Jul 19, 2021
kkourt
approved these changes
Jul 19, 2021
brb
force-pushed
the
pr/brb/disable-sctp-tests
branch
from
367c22d
to
d8a6ce8
Compare
The test case is supposed to test whether the BPF NAT engine doesn't drop packets of a type which it doesn't support (e.g. SCTP). However, recently the test case became flaky. Considering this and a little value the test provides, let's remove the test case. Instead, we should create a BPF unit test for it once it's available (#16862). Signed-off-by: Martynas Pumputis <m@lambda.lt>
|
Considering that the new change after the net-next had passed is the removal of the manifest file (not used by any of the tests), marking it as ready to merge. |
brb
added
the
ready-to-merge
tklauser
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test case is supposed to test whether the BPF NAT engine doesn't
drop packets of a type which it doesn't support (e.g. SCTP). However,
recently the test case became flaky. Considering this and a little value
the test provides, let's remove the test case.
Instead, we should create a BPF unit test for it once it's available
(#16862).
I've reopened #10541 and updated the description.
Fix #16838
Fix #16839