Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf: Remove duplicate define from MAX_BASE_OPTIONS #16911

Merged
merged 1 commit into from Jul 20, 2021
Merged

bpf: Remove duplicate define from MAX_BASE_OPTIONS #16911

merged 1 commit into from Jul 20, 2021

Conversation

christarazi
Copy link
Member

It is redundant.

Signed-off-by: Chris Tarazi chris@isovalent.com

@christarazi
bpf: Remove duplicate define from MAX_BASE_OPTIONS
ca1f5a6 
It is redundant.

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi christarazi requested review from a team as code owners July 15, 2021 23:14
@christarazi christarazi added needs-backport/1.10 sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. area/build Anything to do with the build, more general then area/CI kind/cleanup This includes no functional changes. labels Jul 15, 2021
@christarazi christarazi requested a review from kkourt July 15, 2021 23:14
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 15, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.4 Jul 15, 2021
@christarazi christarazi added release-note/misc This PR makes changes that have no direct user impact. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jul 15, 2021
@christarazi
Copy link
Member Author

test-only --focus="K8sVerifier"

@aanm aanm merged commit eb11c14 into cilium:master Jul 20, 2021
@christarazi christarazi deleted the pr/christarazi/fix-dupe-bpf-makefile branch July 21, 2021 06:22
@aanm aanm mentioned this pull request Jul 21, 2021
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport done to v1.10 in 1.10.4 Sep 1, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport done to v1.10 in 1.10.4 Sep 1, 2021
@joestringer joestringer mentioned this pull request Sep 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkourt kkourt kkourt approved these changes

Assignees
No one assigned
Labels
area/build Anything to do with the build, more general then area/CI kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
No open projects
1.10.4
Backport done to v1.10
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@christarazi @kkourt @joestringer @aanm