Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator: misc. refactoring and code removal #16918

Merged
merged 1 commit into from Jul 29, 2021
Merged

Conversation

aanm
Copy link
Member

@aanm aanm commented Jul 17, 2021

Add better code comments as well as variable names.

Also remove the code handling the GC of CiliumNodes since
that is taken care by Kubernetes has CiliumNodes have owner references
set to the K8s Node.

Signed-off-by: André Martins andre@cilium.io

@aanm aanm added release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.10 labels Jul 17, 2021
@aanm aanm requested a review from a team as a code owner July 17, 2021 01:55
@aanm aanm requested a review from errordeveloper July 17, 2021 01:55
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.4 Jul 17, 2021
@aanm aanm requested review from christarazi and removed request for errordeveloper July 17, 2021 01:56
@aanm
Copy link
Member Author

aanm commented Jul 17, 2021

test-me-please

Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Add better code comments as well as variable names.

Also remove the code handling the GC of CiliumNodes since
that is taken care by Kubernetes has CiliumNodes have owner references
set to the K8s Node.

Signed-off-by: André Martins <andre@cilium.io>
@aanm
Copy link
Member Author

aanm commented Jul 28, 2021

test-me-please

@aanm aanm merged commit 94f94e5 into cilium:master Jul 29, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 29, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.10.4 Aug 10, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.10 in 1.10.4 Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.4
Backport done to v1.10
Development

Successfully merging this pull request may close these issues.

None yet

5 participants