Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add developer build option to disable optimizations #16923

Merged
merged 1 commit into from Aug 5, 2021
Merged

Add developer build option to disable optimizations #16923

merged 1 commit into from Aug 5, 2021

Conversation

xyz-li
Copy link
Contributor

@xyz-li xyz-li commented Jul 19, 2021

Signed-off-by: LiHui andrewli@yunify.com

Fixes: #16922

disable optimization
6cb4ef4 
Signed-off-by: LiHui <andrewli@yunify.com>
@xyz-li xyz-li requested a review from a team as a code owner July 19, 2021 09:15
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 19, 2021
@michi-covalent michi-covalent added the release-note/misc This PR makes changes that have no direct user impact. label Jul 19, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 19, 2021
@joestringer joestringer changed the title disable optimization Add developer build option to disable optimizations Jul 20, 2021
@xyz-li
Copy link
Contributor Author

xyz-li commented Jul 21, 2021

@cilium/docker

@xyz-li
Copy link
Contributor Author

xyz-li commented Jul 21, 2021

@cilium/build

@qmonnet qmonnet requested review from a team and aanm and removed request for a team July 22, 2021 15:56
@qmonnet qmonnet added the area/docker Impacts the integration with Docker. label Jul 22, 2021
@aanm
Copy link
Member

aanm commented Jul 23, 2021

test-me-please

@christarazi christarazi removed the request for review from michi-covalent August 5, 2021 00:52
@christarazi christarazi added area/build Anything to do with the build, more general then area/CI kind/enhancement This would improve or streamline existing functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Aug 5, 2021
@gandro gandro merged commit 6908e98 into cilium:master Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christarazi christarazi christarazi approved these changes

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
area/build Anything to do with the build, more general then area/CI area/docker Impacts the integration with Docker. kind/enhancement This would improve or streamline existing functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NOOPT not works when build container images
6 participants
@xyz-li @aanm @christarazi @gandro @qmonnet @michi-covalent