Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.gitattributes: Hide Documentation/_static. #16929

Merged

Conversation

joestringer
Copy link
Member

@joestringer joestringer commented Jul 19, 2021

Treat Documentation/_static and *svg as binary in git so that when performing a
git diff or git grep, it prints just one line diff rather than matching
the content of some terse javascript file:

$ git grep "\.fo"
Binary file Documentation/_static/copybutton.js matches

@joestringer joestringer requested a review from a team as a code owner July 19, 2021 18:42
@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Jul 19, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jul 19, 2021
Treat Documentation/_static and SVG files as binary in git so that when
performing a git diff or git grep, it prints just one line diff rather
than matching the content of some terse javascript file. This reduces
the noise greatly for greps of short strings to instead print the
following:

    $ git grep "\.fo"
    Binary file Documentation/_static/copybutton.js matches

Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer joestringer force-pushed the submit/hide-static-from-git-textdiff branch from 8754141 to e711053 Compare July 20, 2021 00:55
Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! My grepping was suffering from this.

@joestringer joestringer merged commit 4814dc3 into cilium:master Jul 22, 2021
@joestringer joestringer deleted the submit/hide-static-from-git-textdiff branch July 22, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants