contrib: Improve release script guard rails #16936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
joestringer
commented
Jul 20, 2021
joestringer
commented
- Print help if zero args are provided
- Pick up on invalid URLs with a simple regex to avoid failing early
- Add the actions URL to the commit and PR messages.
* Print help if zero args are provided * Pick up on invalid URLs with a simple regex to avoid failing early * Add the actions URL to the commit and PR messages. Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
added
needs-backport/1.10
release-note/misc
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
aditighag
approved these changes
Jul 22, 2021
|
👍 thanks for the review. I'm not too worried about the impacts, I did try it out during the last release cycle, seemed to do the right thing. All of these release scripts are just slowly getting better incrementally through these individual steps. |
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.4
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.10
in 1.10.4
joestringer
moved this from Needs backport from master
to Backport done to v1.8
in 1.8.12
This was referenced Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.