Documentation: dont use docker for check-cmdref

[kkourt]

check-cmdref just uses bash and git, so there is no reason to run it in
a container.

At the same time, running it in a container causes the script to not
work when using it in a directory created with git clone --reference,
because in this case git object live outside of the directory that is
mounted in the docker container and git diff will fail.

Signed-off-by: Kornilios Kourtis kornilios@isovalent.com

[joestringer]

LGTM. Will request @errordeveloper to also take a look since he introduced this change originally.

[errordeveloper]

So from my point of view, the documentation ought to be containerised to isolate Python from the rest of the build dependencies, which have nothing to do with Python. That idea was extended to "anything to do with Documentation/ belongs to documentation build and should thereby be done in the same container", which matters in practice when it comes to cross-builds, e.g. a macOS or Windows user may wish to run documentation checks against cross-compiled Linux binaries (because Cilium only compiles for Linux), and they'd only be able to do that if the checks run in a Linux container.
From what it looks like, the main part of documentation build remains unchanged, so Python is remains an isolated dependency, and it's only some elements of the documentation build will be executed outside of a container. Either way, I don't object on the basis of my theoretical/idealist view, if folks have good reasons to make any changes to the documentation build, I won't object.

[kkourt]

Thanks @errordeveloper. Indeed there is a concrete use-case for this, which is having mulitple git repositories that share their objects. As you said, the documentation is still build within a container, it is only the check on whether we need to update things that has changed.

I'll mark this ready-to-merge

[kkourt]

Note that the changes only changes a check to be executed outside of a container, so no further testing is required.