Add workflows for stable branches #16944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps developers to know which trigger they can use to retest the l4lb GH workflow. Signed-off-by: André Martins <andre@cilium.io>
Since `issue_comment` is only triggered in GH workflows of the default branch, we need to add a copy of the conformance GH workflows in the default branch as well. This will allow the conformance tests to be tested against stable branches, which right now only 1.10 has support for this. Signed-off-by: André Martins <andre@cilium.io>
aanm
force-pushed
the
pr/add-stable-workflows
branch
from
c05f667
to
fc9390b
Compare
joestringer
approved these changes
Jul 21, 2021
nbusseneau
approved these changes
Jul 21, 2021
| rm eksctl_$(uname -s)_amd64.tar.gz | ||
|
|
||
| - name: Set up AWS CLI credentials | ||
| uses: aws-actions/configure-aws-credentials@13d241b293754004c80624b5567555c4a39ffbe3 |
There was a problem hiding this comment.
Nit: #16942
Suggested change
| uses: aws-actions/configure-aws-credentials@13d241b293754004c80624b5567555c4a39ffbe3 | |
| uses: aws-actions/configure-aws-credentials@0d9a5be0dceea74e09396820e1e522ba4a110d2f |
There was a problem hiding this comment.
Let's wait for the dependabot to do this automatically
| rm eksctl_$(uname -s)_amd64.tar.gz | ||
|
|
||
| - name: Set up AWS CLI credentials | ||
| uses: aws-actions/configure-aws-credentials@13d241b293754004c80624b5567555c4a39ffbe3 |
There was a problem hiding this comment.
Nit: #16942
Suggested change
| uses: aws-actions/configure-aws-credentials@13d241b293754004c80624b5567555c4a39ffbe3 | |
| uses: aws-actions/configure-aws-credentials@0d9a5be0dceea74e09396820e1e522ba4a110d2f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
issue_commentis only triggered in GH workflows of the defaultbranch, we need to add a copy of the conformance GH workflows in the
default branch as well. This will allow the conformance tests to be
tested against stable branches, which right now only 1.10 has support
for this.