install: Fix README links to getting started guides #16947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joestringer
added
needs-backport/1.10
release-note/misc
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
Fix two issues in the README links for getting started guides: * Bad formatting of the image for the Self-Managed K8s option * Broken links to the docs page for getting started. Link all of the links to the same page, like we do on cilium.io. Fixes: 3662560 ("Add new unified Helm guide") Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
force-pushed
the
submit/fix-helm-readme
branch
from
9ec92ab
to
2132165
Compare
|
Basic sanity checks should be sufficient to pick up on any issues here, it's just a README template + the README being changed. No need to trigger Ginkgo/CLI-based tests. |
|
Ilya is on PTO, attempting to reset review requests. |
christarazi
approved these changes
Jul 29, 2021
michi-covalent
approved these changes
Jul 29, 2021
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.4
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.10
in 1.10.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix two issues in the README links for getting started guides:
Link all of the links to the same page, like we do on cilium.io.
Fixes: 3662560 ("Add new unified Helm guide")
Before (left) vs. After (right)