docs: clarify language on libceph and kernel 5.8 in kubeproxy-free GSG #16969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
qmonnet
requested changes
Jul 22, 2021
qmonnet
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
qmonnet
added
area/documentation
qmonnet
changed the title
qmonnet
reviewed
Jul 22, 2021
It was not clear if kernel v5.8 has problem with libceph or if 5.8 fixes the problem. Redo the sentence based on feedback to make it more clear and easy to read. Signed-off-by: Ville Ojamo <bluikko@users.noreply.github.com>
Done. |
qmonnet
added
the
ready-to-merge
This was referenced Oct 4, 2021
This was referenced Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In kube-proxy free documentation limitations section it was not totally clear what libceph worked with. The current text could be interpreted kernel v5.8 provides the necessary functions but still does not work with libceph.
Make it clear that kernel 5.8 provides the necessary bits to make kubeproxy-free work with libceph. Based on Slack discussion this is what it was supposed to mean.
Signed-off-by: Ville Ojamo bluikko@users.noreply.github.com