Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

policy: Fix derived-from labels #16972

Merged
merged 1 commit into from Jul 27, 2021

Conversation

jrajahalme
Copy link
Member

Use the "allow-any-ingress" label instead of "allow-localhost-ingress"
when allowing all on ingress.

Define a new "allow-remotehost-ingress" label and use that when
allowing remote hosts instead of "allow-localhost-ingress".

Signed-off-by: Jarno Rajahalme jarno@isovalent.com

`allow-any-ingress` and `allow-remotehost-ingress` are now used instead of `allow-localhost-ingress` in policy rule `derivedFrom` list when appropriate.

Use the "allow-any-ingress" label instead of "allow-localhost-ingress"
when allowing all on ingress.

Define a new "allow-remotehost-ingress" label and use that when
allowing remote hosts instead of "allow-localhost-ingress".

Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
@jrajahalme jrajahalme added kind/bug This is a bug in the Cilium logic. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. labels Jul 22, 2021
@jrajahalme jrajahalme requested review from a team and kkourt July 22, 2021 11:22
@jrajahalme jrajahalme force-pushed the pr/jrajahalme/fix-derived-from-labels branch from 4c7b38a to fce6e7b Compare July 22, 2021 11:33
@jrajahalme
Copy link
Member Author

test-me-please

Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 26, 2021
@brb
Copy link
Member

brb commented Jul 27, 2021

@jrajahalme No backports are needed for this?

@brb brb merged commit dd4f60f into cilium:master Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is a bug in the Cilium logic. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants